Skip to content
This repository was archived by the owner on Dec 27, 2022. It is now read-only.

added launch at startup functionality - #1753

Open
matthewauld wants to merge 1 commit into
beakerbrowser:masterfrom
matthewauld:issue1665
Open

added launch at startup functionality#1753
matthewauld wants to merge 1 commit into
beakerbrowser:masterfrom
matthewauld:issue1665

Conversation

@matthewauld

Copy link
Copy Markdown
Contributor

Implements #1665
Alright! So, this is not fully tested but:

  • works on mac
  • don't have a windows box to test, but I followed all the instructions to ensure it works with the auto-updater.
  • doesn't work when running from source (but I don't think you want it to?)
  • linux works, but I cannot seem to find the correct executable path. both process.execPath and app.getPath('exe') give you the file stored in /tmp/.mount_Beakerxxx which seems to have something to do with the builder? I did a bunch of searching, but cannot find the solution. I am sure it is straightforward and if it is easy, you just need to swap out process.execPath on line 889 of browser.js

If you need changes, just let me know!

@pfrazee

pfrazee commented Jul 1, 2020

Copy link
Copy Markdown
Member

Thanks @matthewauld! I'll need to test this out when I'm close to the next build and testing on platforms.

knownasilya added a commit to knownasilya/nomad that referenced this pull request Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants