fix(docker): align standalone essentials network with full compose - #2263
Open
NKchinmayanandu wants to merge 1 commit into
Open
fix(docker): align standalone essentials network with full compose#2263NKchinmayanandu wants to merge 1 commit into
NKchinmayanandu wants to merge 1 commit into
Conversation
|
Contributor
|
| Filename | Overview |
|---|---|
| docker/docker-compose-dev-essentials.yaml | The new default-network name matches the full Compose configuration and existing references to unstract-network; no actionable defect was identified. |
Reviews (1): Last reviewed commit: "fix(docker): align essentials network wi..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
docker-compose-dev-essentials.yamldid not explicitly declare its defaultnetwork, causing standalone execution to create
docker_default.The full Compose configuration uses the explicitly named
unstract-network,and the essentials configuration already configures Traefik to use that network.
This change explicitly names the default network as
unstract-networkso thestandalone essentials configuration uses the same network as the full Compose
configuration.
Relevant Docs
docker/docker-compose.yamldocker/docker-compose-dev-essentials.yamldocs/local-dev-setup-executor-migration.mdRelated Issues or PRs
Fixes #2261
Dependencies Versions
pgvector/pgvector:pg15Notes on Testing
Before the change, running: