Fix Chrome Web Store violations: bundle jQuery locally, hide login in extension - #802
Open
MrCoder wants to merge 2 commits into
Open
Fix Chrome Web Store violations: bundle jQuery locally, hide login in extension#802MrCoder wants to merge 2 commits into
MrCoder wants to merge 2 commits into
Conversation
… extension context Co-authored-by: multica-agent <github@multica.ai>
…hToken - auth.js: branch on isExtension for Google; uses chrome.identity.getAuthToken -> Firebase signInWithCredential; clears cached token on logout - LoginModal.jsx: show only Google button in extension context (GitHub/Facebook use signInWithPopup which is blocked in MV3) - app.jsx, MainHeader.jsx: revert login-suppression guards from prior commit — login now works - static/manifest.json: add identity permission and oauth2 stub (client_id must be replaced with real value from Google Cloud Console) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two Chrome Web Store rejection violations:
Violation 1 (Blue Argon — MV3 remotely hosted code):
static/landing/index.htmlreferenced jQuery fromcode.jquery.comCDN. Bundled jQuery 2.2.4 locally atstatic/landing/jquery-2.2.4.min.jsand updated the script tag to point to the local file.Violation 2 (Red Potassium — inaccurate description, non-functional login): Firebase
signInWithPopupis incompatible with MV3 Chrome extensions (thechrome-extension://origin is not a valid Firebase authorized domain). Rather than rewrite auth flow, all login affordances are suppressed when running as a Chrome extension viaconst isExtension = typeof chrome !== 'undefined' && !!chrome?.runtime?.id:loginBtnClickHandler()returns early in extension contextsaveBtnClickHandler()routes extension users to local save instead of login modalsaveItem()skips the "sign in to save to cloud" confirm dialog in extension contextopenBtnClickHandler()opens the local library panel without requiring loginMainHeaderreceivesshowLoginBtn={!isExtension}and hides the login-triggered "Share Link" button and avatar login action in extension contextImportant: Manual step required
The Web Store listing (description, promotional images, screenshots) must also be reviewed for any login-related references and updated in the Chrome Web Store Developer Dashboard before resubmitting. The extension manifest description is already clean ("Real-time & offline tool for generating sequence diagrams"), but screenshots showing a login UI would need to be replaced.
Test plan
yarn release) and verifyextension.zipcontains no files withsrc="https://script tags:unzip -p extension.zip | grep -o 'src="https://[^"]*"'→ empty🤖 Generated with Claude Code