Update polyfill-library, wp-polyfill-node-contains and wp-polyfill-node-contains#5215
Closed
mdhrshahin20 wants to merge 4 commits intoWordPress:trunkfrom
Closed
Update polyfill-library, wp-polyfill-node-contains and wp-polyfill-node-contains#5215mdhrshahin20 wants to merge 4 commits intoWordPress:trunkfrom
mdhrshahin20 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
…6.0 to 4.7.0 and wp-polyfill-dom-rect 4.6.0 to 4.7.0
desrosj
reviewed
Sep 19, 2023
desrosj
requested changes
Sep 19, 2023
Member
desrosj
left a comment
desrosj
left a comment
There was a problem hiding this comment.
Looks like you also need to run npm install in order to update the package-lock.json file.
src/wp-includes/script-loader.php
Outdated
| 'wp-polyfill-fetch' => '3.6.17', | ||
| 'wp-polyfill-formdata' => '4.0.10', | ||
| 'wp-polyfill-node-contains' => '4.6.0', | ||
| 'wp-polyfill-node-contains' => '4.7.0', |
Member
There was a problem hiding this comment.
This should be updated to match the package version, 4.8.0. Seems this was missed on the last update.a
Author
There was a problem hiding this comment.
@desrosj "wp-polyfill-node-contains" updated to 4.8.0 and run npm install command.
desrosj
reviewed
Sep 21, 2023
Member
|
Thanks @mdhrshahin20! There was one small change I just made. Looks ready to commit. |
Member
|
This was merged in https://core.trac.wordpress.org/changeset/56646. |
Author
|
Thank you @desrosj . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59077
Description:
Update polyfill-library 4.7.0 to 4.8.0 , wp-polyfill-node-contains 4.6.0 to 4.7.0 and wp-polyfill-dom-rect 4.6.0 to 4.7.0
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.