Fix: Inactive links

[3kori]

fixes: #122

[huzaifaalmesbah]

If we add a link like LINK_TO_AGENDA, it creates an invalid URL on the current page (you can see it here: https://make.wordpress.org/test/handbook/team-reps/test-chat-moderator-guide/#3-share-agenda).

It also generates a non-working link like:
https://make.wordpress.org/test/handbook/team-reps/test-chat-moderator-guide/LINK_TO_AGENDA

Instead, we could use a previously published agenda link as an example so it’s valid and clearer.

What do you think?

[Successfulsebunya]

You can use this link https://make.wordpress.org/test/tag/test-chat-agenda/ for agenda as agendas keep changing. The latest Agenda will always be at the top

[3kori]

Yes, I was thinking about what we can do with some of the invalid links. This is a great idea, let me get to it.

[Successfulsebunya]

same link can be used here

[Successfulsebunya]

you can use LINK https://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&changetime=1monthago..&keywords=~needs-testing+has-patch&milestone=!Awaiting+Review&milestone=!&col=id&col=summary&col=status&col=milestone&col=changetime&col=keywords&col=type&col=priority&col=component&order=changetime

[3kori]

Making changes now

[3kori]

This query is a bit limiting; we should change it to be more broader.
https://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&keywords=~needs-testing+has-patch&milestone=!Awaiting+Review&col=id&col=summary&col=status&col=milestone&col=changetime&col=keywords&col=type&col=priority&col=component&desc=1&order=changetime

[3kori]

There are also a bunch of other invalid links.

What if instead of [LINK] we could use [#]? What do you think?
@Successfulsebunya @huzaifaalmesbah

[huzaifaalmesbah]

What if we used [#] instead of [LINK]? What do you think?

However, this might not be a good idea. It could create links like current-page-url/#, and when someone clicks it, the browser may try to navigate to a section marked by # on the same page, causing unexpected jumps within the content.

[3kori]

Oooh yeah. Didn't think of it that way.
What would the sensible solution, leave it as it is or remove the link entirely?

[ozgursar]

What would the sensible solution, leave it as it is or remove the link entirely?

I think we can remove the link and name it Title of Announcement with Link. This would avoid it appear as a broken link if someone clicks.

I also have an idea for both generating the agenda and running the test chat session.
We can build a plugin similar to the test reports plugin, fill in the changing content such as link to agenda, announcements, list of attendees, and it can generate the list of items we can copy paste during the session. This would standardize most of the common text that we need to take care of.

[Successfulsebunya]

What would the sensible solution, leave it as it is or remove the link entirely?

I think we can remove the link and name it Title of Announcement with Link. This would avoid it appear as a broken link if someone clicks.

I also have an idea for both generating the agenda and running the test chat session. We can build a plugin similar to the test reports plugin, fill in the changing content such as link to agenda, announcements, list of attendees, and it can generate the list of items we can copy paste during the session. This would standardize most of the common text that we need to take care of.

This is a very good idea, I second it

[Successfulsebunya]

About these broken links we can use a previous example. You can pull an example of the different links and there sources e.g Always look at the very first post, it is what your looking for

Gutenberg Version Release
Help Test WordPress version

[Successfulsebunya]

There are also a bunch of other invalid links.

What if instead of [LINK] we could use [#]? What do you think? @Successfulsebunya @huzaifaalmesbah

use real links as someone needs to also see what should be there

[3kori]

Okay, if we are using real links. We should also include a note that says something like:

Note

Some of the links are used for demonstration.

What do y'all think?
Feel free to co-author the changes you have in mind.

[ozgursar]

Okay, if we are using real links. We should also include a note that says something like:

Note

Some of the links are used for demonstration.

What do y'all think? Feel free to co-author the changes you have in mind.

I think this is a good solution if we are going to use real links.

[huzaifaalmesbah]

We can use code blocks with placeholder links, this won’t be clickable and won’t lead to an invalid link. this might make it easier to copy and paste into Slack or update later. This would be useful for WordPress ecosystem announcements, including announcement links and calls for testing.

[3kori]

@huzaifaalmesbah Could your suggested changes to this branch?
I don't think I have understood how to do that.

[huzaifaalmesbah]

@3kori Sorry for my previous comment, it was confusing. I tried testing the code block approach, but when copying and pasting into Slack, it doesn’t work as expected.

So I think it’s better to proceed with real links in this PR for now. We can look into this again later and open another PR if we find a better solution.

Thanks!

[huzaifaalmesbah]

@3kori Could you please update the PR with the real links when you have time?

List announcements with links and List testing needs section.

[3kori]

@huzaifaalmesbah @ozgursar @Successfulsebunya
PR update, I believe it's ready.

[huzaifaalmesbah]

Looks good to me

[ozgursar]

Looks good to me too.
I'm just curious, should we add any note about the monthly huddles? It's format is a bit different than the chat version.