Fix TapToPlace not starting when called before its Start (#784) - #785
Merged
AMollis merged 1 commit intoJun 24, 2024
Merged
Conversation
anonymous2585
requested review from
a team,
AMollis,
marlenaklein-msft and
shaynie
as code owners
June 19, 2024 14:10
anonymous2585
force-pushed
the
fix/tap-to-place-784
branch
2 times, most recently
from
June 19, 2024 16:08
be5fb2b to
743aed7
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AMollis
requested changes
Jun 19, 2024
AMollis
requested changes
Jun 19, 2024
Contributor
|
@anonymous2585 please rebranch and reapply your changes. We had to do a history reset on main. Please update your fork's Alternatively, you can delete and recreate your fork. |
AMollis
added
the
Status: Do Not Merge
anonymous2585
force-pushed
the
fix/tap-to-place-784
branch
from
June 24, 2024 09:59
743aed7 to
009c559
Compare
anonymous2585
force-pushed
the
fix/tap-to-place-784
branch
from
June 24, 2024 10:01
009c559 to
d402ecb
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AMollis
approved these changes
Jun 24, 2024
AMollis
removed
the
Status: Do Not Merge
ms-RistoRK
added a commit
that referenced
this pull request
Jul 12, 2024
* Fixing some change log format bugs (#791) * Fix TapToPlace not starting when called before its Start (#784) (#785) Co-authored-by: Anonymous <none@gmail.com> * Fix for InputSimulator not executing before InteractionManager (#794) (#795) * Fix for InputSimulator not executing before InteractionManager * Updated changelog.md accordingly * Fixing patch version for PR 794 (#796) * Fix RC pipeline serviceconnection (#835) FixRC * Fixing powershell install action in unity pipeline (#844) --------- Co-authored-by: Adam Mollis <36461279+AMollis@users.noreply.github.com> Co-authored-by: anonymous2585 <148471165+anonymous2585@users.noreply.github.com> Co-authored-by: Anonymous <none@gmail.com> Co-authored-by: Marlena Klein <125413876+marlenaklein-msft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #784
Added non-regression test.
Also corrected comments in tests.