Fixes buttons of secondary keyboard layouts not making any sound - #648
Merged
marlenaklein-msft merged 2 commits intoFeb 20, 2024
Merged
Conversation
LocalJoost
requested review from
a team,
AMollis,
marlenaklein-msft and
shaynie
as code owners
February 16, 2024 12:21
marlenaklein-msft
approved these changes
Feb 16, 2024
Contributor
|
thanks for the fix! |
Contributor
Author
|
You are welcome! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NonNativeKeyboard consists out of several panes. the keyboard_Alpha and keyboard_Space_Alpha are active. However, if you press the &123 button, the keyboard_Symbols gets active. The buttons on this pane do not make sound, because it uses
GetComponentsInChildren<Button>()to find the button, which only finds active game objects, while it should useGetComponentsInChildren<Button>(true), which finds both active and inactive game objects