Fixing the clear color on MRTK's default rig (should be clearing with a 0 alpha) - #517
Merged
AMollis merged 2 commits intoOct 19, 2023
Conversation
…HoloLens's Mixed Reality Capture videos.
AMollis
requested review from
a team,
marlenaklein-msft and
shaynie
as code owners
October 18, 2023 20:31
AMollis
added
the
Package: Input
marlenaklein-msft
approved these changes
Oct 18, 2023
shaynie
approved these changes
Oct 18, 2023
AMollis
enabled auto-merge (squash)
October 18, 2023 20:50
keveleigh
approved these changes
Oct 18, 2023
keveleigh
left a comment
keveleigh
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me! Looks like it'll match the rig's camera's existing default with this change.
Contributor
|
This is an issue on our device as well and has to be set to 0 to get good captures in certain scenarios. Welcome change of defaults!! |
whebertML
approved these changes
Oct 18, 2023
AMollis
added
the
Type: Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A camera clear color with an alpha value of non-zero will show-up on HoloLens's Mixed Reality Capture videos.
Fixes: