Fix regex in repackaging script - #427
Merged
shaynie merged 1 commit intoAug 21, 2023
Merged
Conversation
…e was grabbing the wrong version in some instances. Fixed.
marlenaklein-msft
approved these changes
Aug 21, 2023
shaynie
added a commit
that referenced
this pull request
Aug 21, 2023
IssueSyncBot
pushed a commit
that referenced
this pull request
Aug 21, 2023
…2022.3.2f1 (#430) * Fix regex in repackaging script (#427) The regex for extracting the version number from the package.json file was grabbing the wrong version in some instances. Fixed. (cherry picked from commit 20a0728) * Fix ExperimentalDrawer.cs doesn't compile in Unity Editor 2022.3.2f1 and above. #40 Use a cached height calculated in OnGUI().
shaynie
added a commit
to shaynie/swhMRTKFork
that referenced
this pull request
Aug 21, 2023
…le in Unity Editor 2022.3.2f1 (MixedRealityToolkit#430) * Fix regex in repackaging script (MixedRealityToolkit#427) The regex for extracting the version number from the package.json file was grabbing the wrong version in some instances. Fixed. (cherry picked from commit 20a0728) * Fix ExperimentalDrawer.cs doesn't compile in Unity Editor 2022.3.2f1 and above. MixedRealityToolkit#40 Use a cached height calculated in OnGUI(). (cherry picked from commit 770b1c4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex for extracting the version number from the package.json file was grabbing the wrong version in some instances. Fixed.