Add SmartScreen as origin feature to TrustedOriginSetting spec - #5596
Open
HarshaNP (GittyHarsha) wants to merge 4 commits into
Open
Add SmartScreen as origin feature to TrustedOriginSetting spec#5596HarshaNP (GittyHarsha) wants to merge 4 commits into
HarshaNP (GittyHarsha) wants to merge 4 commits into
Conversation
HarshaNP (GittyHarsha)
commented
May 19, 2026
HarshaNP (GittyHarsha)
commented
Contributor
- Add COREWEBVIEW2_ORIGIN_FEATURE_SMART_SCREEN enum with documentation describing per-origin SmartScreen reputation check configuration.
- Update C++, .NET examples and MIDL3 enum to include SmartScreen.
Add COREWEBVIEW2_ORIGIN_FEATURE_SMART_SCREEN enum with documentation describing per-origin SmartScreen reputation check configuration. Update C++, .NET examples and MIDL3 enum to include SmartScreen. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
HarshaNP (GittyHarsha)
requested review from
Copilot and
David Risney (david-risney)
May 19, 2026 10:11
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the TrustedOriginSetting specification to allow per-origin configuration of SmartScreen reputation checks, updating the associated Win32/C++ and .NET/WinRT examples and the MIDL3 enum to include the new origin feature.
Changes:
- Adds
COREWEBVIEW2_ORIGIN_FEATURE_SMART_SCREEN/CoreWebView2OriginFeature.SmartScreenas a configurable origin feature. - Updates C++ and .NET examples to demonstrate configuring SmartScreen per-origin.
- Expands spec documentation for SmartScreen behavior and updates
SetOriginFeaturesdocs to mention it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
David Risney (david-risney)
approved these changes
May 19, 2026
David Risney (david-risney)
left a comment
David Risney (david-risney)
left a comment
Contributor
There was a problem hiding this comment.
This is good, but please also address the comment about adding a note about security when disabling - that we only want to do this for known and trusted sites.
- Replace hardcoded ICoreWebView2Settings8 reference with link to IsReputationCheckingRequired docs, describe as per-WebView setting - Add security warning about disabling SmartScreen only for trusted origins - Restore COREWEBVIEW2_ORIGIN_FEATURE_STATE doc comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
HarshaNP (GittyHarsha)
force-pushed
the
user/harshanp/origin-settings-add-smartscreen
branch
from
May 19, 2026 23:36
a6c9e08 to
60c61d5
Compare
…quired internals Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
HarshaNP (GittyHarsha)
force-pushed
the
user/harshanp/origin-settings-add-smartscreen
branch
from
May 20, 2026 00:06
0ab4c9e to
cc3a119
Compare
David Risney (david-risney)
requested changes
May 27, 2026
Address PR review comments from oldnewthing and david-risney: - Rename SMART_SCREEN to REPUTATION_CHECKING throughout the spec to avoid marketing names and align with existing IsReputationCheckingRequired API terminology. - Add trailing comma in C++ example array for easier future updates. - Fix default state docs: unconfigured origins follow IsReputationCheckingRequired (not always Enabled). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.