Fix chunk indexing in world previews - #2517
Merged
FormallyMyles merged 2 commits intoAug 19, 2026
Merged
Conversation
FormallyMyles
requested changes
Aug 19, 2026
Collaborator
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix overlapping chunk positions in world previews.
World previews store the chunks in each 32×32 region using a 10-bit index. The X coordinate was shifted by four bits instead of five, causing different chunk positions to share the same index.
What changed
Impact
All 1,024 possible chunk positions in a region now receive unique indexes instead of overlapping.
Validation
./gradlew :cli:test --tests com.hivemc.chunker.conversion.intermediate.column.chunk.ChunkCoordPairTests0through1023range.