Add rounded iframe sample - #1421
Open
ttw225 wants to merge 8 commits into
Open
Conversation
demonstrates how to use an iframe with rounded corners in a Chrome Extension
…rettier formatting rules replaced double quotes with single quotes, adjusted indentation and line breaks
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…anifest.json, iframe-styles.css
…d tighten URL guard in service-worker
shorten overview and move inspiration into a brief note
Author
|
@dkocich Thanks a lot for the detailed review and suggestions! I’ve addressed all three points you mentioned. Please let me know if there’s anything else I should adjust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new sample
sample.rounded-iframe, which demonstrates how to use an iframe with rounded corners in a Chrome Extension.