The Wayback Machine - https://web.archive.org/web/20201209133608/https://github.com/developit/microbundle/pull/714
Skip to content

/ microbundle

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bring back @babel/env preset match #714

Merged
merged 2 commits into from Sep 2, 2020
Merged

fix: bring back @babel/env preset match #714

merged 2 commits into from Sep 2, 2020

Conversation

@wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented Sep 1, 2020 •
edited

@developit added @babel/env check again to microbundle. Npm doesn't have the package https://www.npmjs.com/package/@babel/env. It's the reason why I removed it so unsure what alias is meant in #702 (comment). I'll change the comment in this PR to be more descriptive when I get more info.

Got removed in #702 (comment)

Note: this does not need a changeset
@wardpeet
fix: bring back @babel/env preset match
Verified
This commit was signed with a verified signature.
wardpeet Ward Peeters
GPG key ID: 071EE4D015FEEB90 Learn about signing commits
Loading status checks…
f7af9ed
@wardpeet wardpeet requested a review from developit Sep 1, 2020
@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Sep 1, 2020 •
edited

💥 No Changeset

Latest commit: 120c7a6

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR
@wardpeet wardpeet marked this pull request as draft Sep 1, 2020
@developit
developit approved these changes Sep 1, 2020
View changes
@wardpeet
Copy link
Collaborator Author

@wardpeet wardpeet commented Sep 1, 2020

@developit where can I find more info on the @babel/env alias part?
@developit
Copy link
Owner

@developit developit commented Sep 1, 2020

@wardpeet https://babeljs.io/docs/en/presets#preset-shorthand
@wardpeet
update comment
Verified
This commit was signed with a verified signature.
wardpeet Ward Peeters
GPG key ID: 071EE4D015FEEB90 Learn about signing commits
Loading status checks…
120c7a6
@wardpeet wardpeet marked this pull request as ready for review Sep 2, 2020
@wardpeet wardpeet merged commit 7b2ff57 into developit:master Sep 2, 2020
2 checks passed
2 checks passed
build (12.x)
Details
build (14.x)
Details
@wardpeet wardpeet deleted the wardpeet:fix/preset-env branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@wardpeet @developit
You can’t perform that action at this time.