Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd more scopes to the tree sitter grammar #288
Merged
Conversation
Exceptions -> support.type.exception integer&float -> numeric add @ and @= operator
|
@Ben3eeE for declarative changes like this on an area you know well (such as TreeSitter languages), I'd feel comfortable with you merging at will if you don't get a timely review. So long as you're willing to help us out if you end up breaking something, which I think you're good for. Thanks for pushing this forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


Ben3eeE commentedNov 23, 2018
•
edited
Description
This PR adds the suggested changes from #257 using the latest tree-sitter-python and API.
We are using:
'binary_operator > "@"': 'keyword.operator'To avoid highlighting the
@indecorated_definition > decorator > "@"askeyword.operatorin f.ex.:Open questions
raise Exception('a')syntax. The exception is scoped as a function call (entity.name.function). ShouldExceptionbesupport.type.exceptionin this case as well?__build_class__BuiltinImporterI used the list from https://docs.python.org/3/library/functions.html when adding the current functions. Are these two functions and should be added?
Issues
Supersedes and closes #257
Fixes #295
/cc @ambv @maxbrunsfeld