Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow JS snippets to be used in Flow files #651
+1
−1
Conversation
nathansobo
merged commit 5242707
into
master
Jun 26, 2019
nathansobo
deleted the
ns/flow-snippets
branch
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nathansobo commentedJun 26, 2019
Fixes atom/language-typescript#29
Flow files are actually handled by
language-typescript, but the JS snippets should all be applicable in that context. To address this, I add.source.flowto the selector for the JS snippets in this PR.