Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upswap button colors to emphasize `Comment` more than `Resolve Conversa… #2115
Conversation
…tion`
codecov
bot
commented
May 2, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #2115 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 207 207
Lines 12045 12045
Branches 1764 1764
=======================================
Hits 11160 11160
Misses 885 885
Continue to review full report at Codecov.
|
smashwilson
added this to In progress
in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0
via automation
smashwilson
moved this from In progress
to Merged
in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vanessayuenn commentedMay 1, 2019
I kept clicking "Resolve conversation" instead of "Comment" by accident, because the bright color of
btn-primarycalled to me. This PR swaps the colors of those two buttons, since "Comment" is more likely to be the button a user means to click.