Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `NODE_ENV=development` to `test` script to see React errors #2113
Conversation
React runs fewer checks in production mode for efficiency. For example, in development mode it checks that props have not been mutated. We had an issue where tests were failing on CI due to mutated props but not locally until we set the NODE_ENV to be development. Let's just have this always be the case to err on the side of catching more errors locally. Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
codecov
bot
commented
May 1, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #2113 +/- ##
==========================================
+ Coverage 92.65% 92.66% +<.01%
==========================================
Files 207 207
Lines 12045 12045
Branches 1764 1764
==========================================
+ Hits 11160 11161 +1
+ Misses 885 884 -1
Continue to review full report at Codecov.
|
|
|
smashwilson
added this to In progress
in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0
via automation
smashwilson
moved this from In progress
to Merged
in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kuychaco commentedMay 1, 2019
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
This PR sets our
testscript to run withNODE_ENV=development. Doing so helped us catch/debug a React issue as described in f60d186Rationale: React runs fewer checks in production mode for efficiency. For example, in development mode it checks that props have not been mutated but in production mode it seems that it does not. We had an issue where tests were failing on CI due to mutated props but not locally until we set the NODE_ENV to be development. Presumably our CI is running with development mode by default. Let's just have this always be the case to err on the side of catching more errors locally.
Screenshot/Gif
N/A
Alternate Designs
N/A
Benefits
Catch bugs more easily / faster!
Possible Drawbacks
None.
Applicable Issues
See f60d186
Metrics
N/A
Tests
N/A
Documentation
N/A
Release Notes
User Experience Research (Optional)
N/A