Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReviews dock item #1995
Reviews dock item #1995
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
smashwilson
added this to In progress
in Sprint : 13 February 2019 - 5 March 2019 : v0.27.0
via automation
todo
bot
commented
Mar 4, 2019
todo
bot
commented
Mar 4, 2019
todo
bot
commented
Mar 4, 2019
todo
bot
commented
Mar 4, 2019
todo
bot
commented
Mar 4, 2019
codecov
bot
commented
Mar 14, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #1995 +/- ##
==========================================
- Coverage 92.58% 92.49% -0.09%
==========================================
Files 189 207 +18
Lines 11244 12010 +766
Branches 1634 1745 +111
==========================================
+ Hits 10410 11109 +699
- Misses 834 901 +67
Continue to review full report at Codecov.
|
Our tests were failing because we were rendering the fragment container instead of the direct component.
Co-Authored-By: Vanessa Yuen <vanessayuenn@users.noreply.github.com>
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
|
Finished up reviewing the mutations and views, as well as all of the changes based on my review feedback. Everything looks good! Great job everyone! Left a couple of comments, nothing blocking. It's time to |
| } | ||
|
|
||
| // "forceRerender" ensures that the PullRequestReviewCommentThreadView re-renders each time that the | ||
| // MultiFilePatchView does. It doesn't re-query for reviews, but it does re-check patch visibility. |
This comment has been minimized.
This comment has been minimized.
kuychaco
Apr 6, 2019
Member
I believe this comment is simply stale and we don't need to worry about re-rendering, right @smashwilson?
This comment has been minimized.
This comment has been minimized.
| </summary> | ||
| <nav className="github-Review-nav"> | ||
| <button className={openFileClasses} | ||
| data-path={nativePath} data-line={lineNumber} data-diff={rootComment.diffHunk} |
This comment has been minimized.
This comment has been minimized.
|
I've filed issues for the remaining refactor-y bits of feedback so we don't lose track of them. Thanks for the super-thoughtful review as always, @kuychaco
|
|
AHHH this is so exciting! Let's ship it! |
smashwilson
merged commit 728b974
into
master
mcrocker
commented
Apr 15, 2019
|
This stuff looks amazing. Great work! Does this work with GitLab Merge Requests, or are the plans too make it GitLab compatible, or is the a GitLab equivalent feature somewhere else? |
|
@mcrocker thanks! we have no plans to build a GitLab integration into our package. Good news, though. Atom does have some community packages for GitLab integration. I'd try filing an issue at https://github.com/blakawk/gitlab-integration and see if you can work with the folks maintaining that package to get that feature request on their roadmap. |
smashwilson commentedMar 1, 2019
•
edited by vanessayuenn
Description of the Change
View pull request reviews and review comments in a dock item.
vy/prototype-for-uxrScreenshot/Gif
TODO
Benefits
Pull request authors will now enjoy many features for responding to code review comments from the comfort of their editor.
Metrics
='open-reviews-tab', {package: 'github', from: IssueishDetailController});open-review-thread', {package: 'github'}'reviews-dock-open-file', {package: 'github'});'reviews-dock-open-diff', {package: 'github'});'reviews-dock-open-pr', {package: 'github', component: this.constructor.name});'reviews-dock-show-more-context', {package: 'github'});'reviews-dock-show-less-context', {package: 'github'});'resolve-comment-thread', {package: 'github'});'unresolve-comment-thread', {package: 'github'});'add-single-comment', {package: 'github'});'start-pr-review', {package: 'github', component: (ReviewsFooterView or ReviewsView})'add-emoji-reaction', {package: 'github'});-removing an emoji reaction
'remove-emoji-reaction', {package: 'github'});Tests
QA checklist:
PR detail view
Comment dock
In-editor decorations
Other
Documentation
See📈 Feature project
Release Notes
The GitHub integration now displays pull request review comments in a dock, and supports replying to comments, emoji reacting to comments, and resolving comments.
User Experience Research (Optional)
We conducted 6 user interviews while developing the prototype for this feature.