Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Don't ignore *.pot files. #3086
Conversation
Although dynamically generated from i18n tools, in some situations (specially in the Plone world) you need to add a manual.pot with manual entries that need to be versioned. More information: https://github.com/plone/documentation/blob/0ea1b1f715e9031a434d72f57c189f25aa1f4b73/develop/plone/i18n/internationalisation.rst#manual-po-entries
|
@shiftkey can you take a look here please? |
| @@ -52,7 +52,6 @@ coverage.xml | |||
|
|
|||
| # Translations | |||
| *.mo | |||
| *.pot | |||
shiftkey
Dec 3, 2020
Member
This rule has been largely unchanged for 7+ years, so I have several concerns about dropping this:
- Most
.potfiles are generated, right? Would this be noisy to now have all.potfiles in version control? - For situations where include/exclude files from version control is situational, we like to have a comment with context about when and why you should care about this rule. Here's an example:
Lines 24 to 25 in 218a941
Can we do that for this case, to explain for Plone usage what they should be aware of?
- if we're trying to exclude a specific file by convention, could we keep this rule but add a
!manual.potor!lib/manual.potrule to opt-in for this specific file?
|
@idgserpro the other concern I have about this change is interest from the community - I'm not familiar with Plone so I'm not sure how many people out there agree with this change. |
|
Your concerns are valid. Actually, I don't know the motivation to version control *.pot files, but this has been for ages in Plone world. @mauritsvanrees would you have more information about this? |
|
I am one of the Plone Release managers. I am indeed used to having the Some reasons for versioning the
Something like |
Reasons for making this change:
Although dynamically generated from i18n tools, in some situations (specially in the Plone world) you need to add a manual.pot with manual entries that need to be versioned.
Links to documentation supporting these rule changes:
https://github.com/plone/documentation/blob/0ea1b1f715e9031a434d72f57c189f25aa1f4b73/develop/plone/i18n/internationalisation.rst#manual-po-entries