Add compat for old single widgets (non-WP_Widget)#37
Merged
JoryHogeveen merged 2 commits intocleverness:devfrom Jul 4, 2019
Merged
Add compat for old single widgets (non-WP_Widget)#37JoryHogeveen merged 2 commits intocleverness:devfrom
JoryHogeveen merged 2 commits intocleverness:devfrom
Conversation
Collaborator
|
Thanks @westonruter! |
JoryHogeveen
approved these changes
Jul 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin currently assumes that
WP_Widgetwill be used for all widgets. This, however, is not always the case. Widgets can still be registered using an earlier API. For example: https://gist.github.com/westonruter/7141599When such an old single widget is present, a PHP notice is the result:
This prevents that from happening.
It would be even better to actually add support for single widgets, but this is better than a notice.